Re: [PATCH] tests/avocado/machine_aspeed.py: Update SDK images

[Cédric Le Goater]

On 8/28/23 15:54, Joel Stanley wrote:
> On Mon, 28 Aug 2023 at 09:01, Cédric Le Goater <clg@kaod.org> wrote:
> > Switch to the latest v8.06 release which introduces interesting
> > changes for the AST2600 I2C and I3C models. Also take the AST2600 A2
> > images instead of the default since QEMU tries to model The AST2600 A3
> > SoC.
>
> Is there any value in testing both the old and the new images?

For QEMU default tests, I think using the latest version of a test image
is just fine, or we will end up with a very long avocado test run. That
said we could make an exception when a HW feature is only activated in a
specific version.

I run pre-PR tests with more images (buildroot, mainline, sdk, openbmc,
provided by other vendors) but only the SDK v08.X images have decent
results. v07.02 and v04.05 have issues. It could be a software issue.

C.


> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> > Signed-off-by: Cédric Le Goater <clg@kaod.org>
> > ---
> >
> >    Requires patches from Hang Yu [1]
> >
> >    [1] 
> > https://lore.kernel.org/qemu-devel/20230812065230.8839-1-francis_yuu@stu.pku.edu.cn/
> >
> >
> >   tests/avocado/machine_aspeed.py | 12 ++++++------
> >   1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/tests/avocado/machine_aspeed.py b/tests/avocado/machine_aspeed.py
> > index 724ee72c0208..90f1b7cb77a1 100644
> > --- a/tests/avocado/machine_aspeed.py
> > +++ b/tests/avocado/machine_aspeed.py
> > @@ -316,8 +316,8 @@ def test_arm_ast2500_evb_sdk(self):
> >           """
> >
> >           image_url = ('https://github.com/AspeedTech-BMC/openbmc/releases/'
> > -                     'download/v08.01/ast2500-default-obmc.tar.gz')
> > -        image_hash = 
> > ('5375f82b4c43a79427909342a1e18b4e48bd663e38466862145d27bb358796fd')
> > +                     'download/v08.06/ast2500-default-obmc.tar.gz')
> > +        image_hash = 
> > ('e1755f3cadff69190438c688d52dd0f0d399b70a1e14b1d3d5540fc4851d38ca')
> >           image_path = self.fetch_asset(image_url, asset_hash=image_hash,
> >                                         algorithm='sha256')
> >           archive.extract(image_path, self.workdir)
> > @@ -334,8 +334,8 @@ def test_arm_ast2600_evb_sdk(self):
> >           """
> >
> >           image_url = ('https://github.com/AspeedTech-BMC/openbmc/releases/'
> > -                     'download/v08.01/ast2600-default-obmc.tar.gz')
> > -        image_hash = 
> > ('f12ef15e8c1f03a214df3b91c814515c5e2b2f56119021398c1dbdd626817d15')
> > +                     'download/v08.06/ast2600-a2-obmc.tar.gz')
> > +        image_hash = 
> > ('9083506135f622d5e7351fcf7d4e1c7125cee5ba16141220c0ba88931f3681a4')
> >           image_path = self.fetch_asset(image_url, asset_hash=image_hash,
> >                                         algorithm='sha256')
> >           archive.extract(image_path, self.workdir)
> > @@ -345,8 +345,8 @@ def test_arm_ast2600_evb_sdk(self):
> >           self.vm.add_args('-device',
> >                            'ds1338,bus=aspeed.i2c.bus.5,address=0x32');
> >           self.do_test_arm_aspeed_sdk_start(
> > -            self.workdir + '/ast2600-default/image-bmc')
> > -        self.wait_for_console_pattern('nodistro.0 ast2600-default ttyS4')
> > +            self.workdir + '/ast2600-a2/image-bmc')
> > +        self.wait_for_console_pattern('nodistro.0 ast2600-a2 ttyS4')
> >
> >           self.ssh_connect('root', '0penBmc', False)
> >           self.ssh_command('dmesg -c > /dev/null')
> > --
> > 2.41.0