[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 6/8] tests/tcg: ensure system-mode gdb tests start stopped
From: |
Alex Bennée |
Subject: |
[PATCH 6/8] tests/tcg: ensure system-mode gdb tests start stopped |
Date: |
Thu, 10 Aug 2023 16:36:38 +0100 |
Without -S we run into potential races with tests starting before the
gdbstub attaches. We don't need to worry about user-mode as enabling
the gdbstub implies we wait for the initial connection.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/guest-debug/run-test.py | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/tests/guest-debug/run-test.py b/tests/guest-debug/run-test.py
index c0d0075e2e..b13b27d4b1 100755
--- a/tests/guest-debug/run-test.py
+++ b/tests/guest-debug/run-test.py
@@ -69,13 +69,10 @@ def log(output, msg):
# Launch QEMU with binary
if "system" in args.qemu:
- cmd = "%s %s %s -gdb unix:path=%s,server=on" % (args.qemu,
- args.qargs,
- args.binary,
- socket_name)
+ cmd = f'{args.qemu} {args.qargs} {args.binary}' \
+ f' -S -gdb unix:path={socket_name},server=on'
else:
- cmd = "%s %s -g %s %s" % (args.qemu, args.qargs, socket_name,
- args.binary)
+ cmd = f'{args.qemu} {args.qargs} -g {socket_name} {args.binary}'
log(output, "QEMU CMD: %s" % (cmd))
inferior = subprocess.Popen(shlex.split(cmd))
--
2.39.2
- [PATCH 2/8] tests/docker: cleanup non-verbose output, (continued)
- [PATCH 2/8] tests/docker: cleanup non-verbose output, Alex Bennée, 2023/08/10
- [PATCH 3/8] tests/tcg: remove quoting for info output, Alex Bennée, 2023/08/10
- [PATCH 4/8] tests: remove test-gdbstub.py, Alex Bennée, 2023/08/10
- [PATCH 5/8] tests/tcg: clean-up gdb confirm/pagination settings, Alex Bennée, 2023/08/10
- [PATCH 8/8] gdbstub: don't complain about preemptive ACK chars, Alex Bennée, 2023/08/10
- [PATCH 6/8] tests/tcg: ensure system-mode gdb tests start stopped,
Alex Bennée <=
- [PATCH 7/8] gdbstub: more fixes for client Ctrl-C handling, Alex Bennée, 2023/08/10
- Re: [PATCH 0/8] some testing and gdbstub fixes, Peter Maydell, 2023/08/10