[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 04/16] accel: Fix a leak on Windows HAX
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v3 04/16] accel: Fix a leak on Windows HAX |
Date: |
Sat, 24 Jun 2023 19:41:09 +0200 |
hThread is only used on the error path in hax_kick_vcpu_thread().
Fixes: b0cb0a66d6 ("Plumb the HAXM-based hardware acceleration support")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
target/i386/hax/hax-all.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/target/i386/hax/hax-all.c b/target/i386/hax/hax-all.c
index 3e5992a63b..a2321a1eff 100644
--- a/target/i386/hax/hax-all.c
+++ b/target/i386/hax/hax-all.c
@@ -205,6 +205,9 @@ int hax_vcpu_destroy(CPUState *cpu)
*/
hax_close_fd(vcpu->fd);
hax_global.vm->vcpus[vcpu->vcpu_id] = NULL;
+#ifdef _WIN32
+ CloseHandle(cpu->hThread);
+#endif
g_free(vcpu);
return 0;
}
--
2.38.1
- [PATCH v3 00/16] accel: Share CPUState accel context (HAX/NVMM/WHPX/HVF), Philippe Mathieu-Daudé, 2023/06/24
- [PATCH v3 01/16] MAINTAINERS: Update Roman Bolshakov email address, Philippe Mathieu-Daudé, 2023/06/24
- [PATCH v3 02/16] accel: Document generic accelerator headers, Philippe Mathieu-Daudé, 2023/06/24
- [PATCH v3 03/16] accel: Remove unused hThread variable on TCG/WHPX, Philippe Mathieu-Daudé, 2023/06/24
- [PATCH v3 04/16] accel: Fix a leak on Windows HAX,
Philippe Mathieu-Daudé <=
- [PATCH v3 05/16] accel: Destroy HAX vCPU threads once done, Philippe Mathieu-Daudé, 2023/06/24
- [PATCH v3 06/16] accel: Rename 'hax_vcpu' as 'accel' in CPUState, Philippe Mathieu-Daudé, 2023/06/24
- [PATCH v3 07/16] accel: Rename HAX 'struct hax_vcpu_state' -> AccelCPUState, Philippe Mathieu-Daudé, 2023/06/24
- [PATCH v3 08/16] accel: Move HAX hThread to accelerator context, Philippe Mathieu-Daudé, 2023/06/24
- [PATCH v3 09/16] accel: Remove NVMM unreachable error path, Philippe Mathieu-Daudé, 2023/06/24
- [PATCH v3 10/16] accel: Rename NVMM 'struct qemu_vcpu' -> AccelCPUState, Philippe Mathieu-Daudé, 2023/06/24
- [PATCH v3 11/16] accel: Inline NVMM get_qemu_vcpu(), Philippe Mathieu-Daudé, 2023/06/24
- [PATCH v3 12/16] accel: Remove WHPX unreachable error path, Philippe Mathieu-Daudé, 2023/06/24
- [PATCH v3 13/16] accel: Rename WHPX 'struct whpx_vcpu' -> AccelCPUState, Philippe Mathieu-Daudé, 2023/06/24