[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v3 4/4] hw/misc/bcm2835_property: Handle CORE_CLK_ID firm
From: |
Peter Maydell |
Subject: |
Re: [RFC PATCH v3 4/4] hw/misc/bcm2835_property: Handle CORE_CLK_ID firmware property |
Date: |
Mon, 19 Jun 2023 14:30:33 +0100 |
On Mon, 12 Jun 2023 at 23:35, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> From: Sergey Kambalin <sergey.kambalin@auriga.com>
>
> Signed-off-by: Sergey Kambalin <sergey.kambalin@auriga.com>
> Message-Id: <20230531155258.8361-1-sergey.kambalin@auriga.com>
> [PMD: Split from bigger patch: 3/4]
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> TOCHECK: seems raspi3-specific freq. Use a per-soc freq? Good enough for now?
Seems like 'good enough for now' to me. We can add a comment:
+/*
+ * TODO: this is really SoC-specific; we might want to
+ * set it per-SoC if it turns out any guests care.
+ */
-- PMM
- [PATCH v3 0/4] hw/arm/raspi: Use named constants in BCM props, Philippe Mathieu-Daudé, 2023/06/12
- [PATCH v3 1/4] hw/arm/raspi: Import Linux raspi definitions as 'raspberrypi-fw-defs.h', Philippe Mathieu-Daudé, 2023/06/12
- [RFC PATCH v3 3/4] hw/misc/bcm2835_property: Replace magic frequency values by definitions, Philippe Mathieu-Daudé, 2023/06/12
- [PATCH v3 2/4] hw/misc/bcm2835_property: Use 'raspberrypi-fw-defs.h' definitions, Philippe Mathieu-Daudé, 2023/06/12
- [RFC PATCH v3 4/4] hw/misc/bcm2835_property: Handle CORE_CLK_ID firmware property, Philippe Mathieu-Daudé, 2023/06/12
- Re: [RFC PATCH v3 4/4] hw/misc/bcm2835_property: Handle CORE_CLK_ID firmware property,
Peter Maydell <=
- Re: [PATCH v3 0/4] hw/arm/raspi: Use named constants in BCM props, Peter Maydell, 2023/06/19