Re: [PATCH v2 24/26] target/arm/tcg: Inline 'exec/helper-proto.h'

[Richard Henderson]

On 6/14/23 14:50, Philippe Mathieu-Daudé wrote:
> We get:
>
> ../../target/arm/tcg/vec_helper.c:268:6: error: no previous prototype for function 
> 'helper_gvec_qrdmlah_s16' [-Werror,-Wmissing-prototypes]
> ../../target/arm/tcg/vec_helper.c:293:6: error: no previous prototype for function 
> 'helper_gvec_qrdmlsh_s16' [-Werror,-Wmissing-prototypes]
> ...
>
> ../../target/arm/vfp_helper.c:511:10: error: no previous prototype for function 
> 'helper_set_rmode' [-Werror,-Wmissing-prototypes]
> ../../target/arm/vfp_helper.c:1127:10: error: no previous prototype for function 
> 'helper_fjcvtzs' [-Werror,-Wmissing-prototypes]
> ...
>
> ../../target/arm/tcg/m_helper.c:581:9: error: call to undeclared function 
> 'helper_exception_internal'; ISO C99 and later do not support implicit function 
> declarations [-Wimplicit-function-declaration]
>
> ../../target/arm/tcg/helper-a64.c:831:9: error: call to undeclared function 
> 'helper_rebuild_hflags_a32'; ISO C99 and later do not support implicit function 
> declarations [-Wimplicit-function-declaration]
>
> ../../target/arm/tcg/psci.c:174:9: error: call to undeclared function 'helper_wfi'; ISO 
> C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>
> ../../target/arm/tcg/tlb_helper.c:168:6: error: no previous prototype for function 
> 'helper_exception_pc_alignment' [-Werror,-Wmissing-prototypes]
>
> ../../target/arm/tcg/crypto_helper.c:73:12: error: function cannot return function type 
> 'void (void *, void *, void *, uint32_t)' (aka 'void (void *, void *, void *, unsigned int)')
> void HELPER(crypto_aese)(void *vd, void *vn, void *vm, uint32_t desc)
>
> Do we need more tcg/helper-foo.h.inc?
> - gvec / simd / crypto
> - exception / wfi

crypto, pauth, mte, for sure.

gvec could go with vfp.
fjcvtzs is definitely vfp.

I doubt a separate header for exceptions would pay off.


r~