[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/5] qemu/uri: Use QueryParams type definition
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 3/5] qemu/uri: Use QueryParams type definition |
Date: |
Tue, 6 Jun 2023 10:22:07 +0100 |
On Mon, 5 Jun 2023 at 18:57, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Follow QEMU CODING_STYLE, use the type definition.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/qemu/uri.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/qemu/uri.h b/include/qemu/uri.h
> index b43f35a6a6..2875c51417 100644
> --- a/include/qemu/uri.h
> +++ b/include/qemu/uri.h
> @@ -96,7 +96,7 @@ typedef struct QueryParams {
> QueryParam *p; /* array of parameters */
> } QueryParams;
>
> -struct QueryParams *query_params_new (int init_alloc);
> +QueryParams *query_params_new (int init_alloc);
> extern QueryParams *query_params_parse (const char *query);
> extern void query_params_free (QueryParams *ps);
Also makes that prototype match the following two.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v2 0/5] bulk: Do not declare function prototypes using 'extern' keyword, Philippe Mathieu-Daudé, 2023/06/05
- [PATCH v2 1/5] util/cacheflush: Use declarations from <OSCacheControl.h> on Darwin, Philippe Mathieu-Daudé, 2023/06/05
- [PATCH v2 2/5] tcg/tcg-op-vec: Remove left over _link_error() definitions, Philippe Mathieu-Daudé, 2023/06/05
- [PATCH v2 3/5] qemu/uri: Use QueryParams type definition, Philippe Mathieu-Daudé, 2023/06/05
- Re: [PATCH v2 3/5] qemu/uri: Use QueryParams type definition,
Peter Maydell <=
- [PATCH v2 4/5] bulk: Do not declare function prototypes using 'extern' keyword, Philippe Mathieu-Daudé, 2023/06/05
- [PATCH v2 5/5] bulk: Replace __attribute__((noreturn)) -> G_NORETURN, Philippe Mathieu-Daudé, 2023/06/05