Re: [PATCH v2 1/1] hw/arm/sbsa-ref: add XHCI controller on PCIe

[Richard Henderson]

On 5/31/23 23:37, Yuquan Wang wrote:
> The current sbsa-ref cannot use EHCI controller which is only
> able to do 32-bit DMA, since sbsa-ref doesn't have RAM below 4GB.
> Hence, this add an XHCI on PCIe to provide a usb controller with 64-bit
> DMA capablity.
>
> Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
> ---
>   hw/arm/sbsa-ref.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> index de21200ff9..a33cd80d69 100644
> --- a/hw/arm/sbsa-ref.c
> +++ b/hw/arm/sbsa-ref.c
> @@ -668,6 +668,8 @@ static void create_pcie(SBSAMachineState *sms)
>   
>       pci_create_simple(pci->bus, -1, "bochs-display");
>   
> +    pci_create_simple(pci->bus, -1, "qemu-xhci");

Better to use TYPE_QEMU_XHCI.
Need to remove the EHCI controler.


r~