Re: [PATCH 0/2] Added 32 bits property for ASPEED GPIO with updated qtests. This change gives ASPEED GPIO similar behavior as Nuvoton.

[Cédric Le Goater]

On 5/31/23 18:55, Jingbo Wu wrote:
> From: Felix Wu <flwu@google.com>

Hello Felix,

Thanks for the extension. It could be useful in some situations but
it seems also dangerous to set all lines controlled by a register
at once. The same comment applies to Nuvoton [1].

C.

[1] 
https://lore.kernel.org/qemu-devel/CAFEAcA-2_gwOUgapmgSSFGVNiOk9Grse_E3TVo=pQTf-OgW2vg@mail.gmail.com/


> Felix Wu (2):
>    hw/gpio: Add property for ASPEED GPIO in 32 bits basis
>    tests/qtest: Add qtest for for ASPEED GPIO gpio-set property
>
>   hw/gpio/aspeed_gpio.c          |  56 ++++++++++++++++++
>   include/qapi/qmp/qdict.h       |   1 +
>   qobject/qdict.c                |  13 ++++
>   tests/qtest/aspeed_gpio-test.c | 105 ++++++++++++++++++++++++++++++---
>   4 files changed, 166 insertions(+), 9 deletions(-)