[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-8.0 v2 2/2] target/arm/pauth: Inline pauth_param_mask() a
From: |
Fabiano Rosas |
Subject: |
Re: [PATCH-for-8.0 v2 2/2] target/arm/pauth: Inline pauth_param_mask() and pauth_ptr_mask() |
Date: |
Tue, 28 Mar 2023 10:55:53 -0300 |
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> aarch64_gdb_get_pauth_reg() -- although disabled since commit
> 5787d17a42 ("target/arm: Don't advertise aarch64-pauth.xml to
> gdb") is still compiled in. It calls pauth_ptr_mask() which is
> located in target/arm/tcg/pauth_helper.c, a TCG specific helper.
>
> To avoid a linking error when TCG is not enabled:
>
> Undefined symbols for architecture arm64:
> "_pauth_ptr_mask", referenced from:
> _aarch64_gdb_get_pauth_reg in target_arm_gdbstub64.c.o
> ld: symbol(s) not found for architecture arm64
> clang: error: linker command failed with exit code 1 (use -v to see
> invocation)
>
> - Rename pauth_ptr_mask_internal() as pauth_param_mask() and
> inline it in "internals.h",
> - Inline pauth_ptr_mask() in "internals.h".
>
> Fixes: e995d5cce4 ("target/arm: Implement gdbstub pauth extension")
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Fabiano Rosas <farosas@suse.de>