[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 10/20] qga: Clean up includes
From: |
Markus Armbruster |
Subject: |
[PATCH v5 10/20] qga: Clean up includes |
Date: |
Mon, 30 Jan 2023 14:21:46 +0100 |
Clean up includes so that qemu/osdep.h is included first in .c, and
not in .h, and headers which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
---
qga/cutils.h | 2 --
qga/commands-posix.c | 1 -
qga/cutils.c | 3 ++-
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/qga/cutils.h b/qga/cutils.h
index f0f30a7d28..c1f2f4b17a 100644
--- a/qga/cutils.h
+++ b/qga/cutils.h
@@ -1,8 +1,6 @@
#ifndef CUTILS_H_
#define CUTILS_H_
-#include "qemu/osdep.h"
-
int qga_open_cloexec(const char *name, int flags, mode_t mode);
#endif /* CUTILS_H_ */
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index ebd33a643c..079689d79a 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -51,7 +51,6 @@
#else
#include <net/ethernet.h>
#endif
-#include <sys/types.h>
#ifdef CONFIG_SOLARIS
#include <sys/sockio.h>
#endif
diff --git a/qga/cutils.c b/qga/cutils.c
index b8e142ef64..b21bcf3683 100644
--- a/qga/cutils.c
+++ b/qga/cutils.c
@@ -2,8 +2,9 @@
* This work is licensed under the terms of the GNU GPL, version 2 or later.
* See the COPYING file in the top-level directory.
*/
-#include "cutils.h"
+#include "qemu/osdep.h"
+#include "cutils.h"
#include "qapi/error.h"
/**
--
2.39.0
- [PATCH v5 01/20] scripts/clean-includes: Fully skip / ignore files, (continued)
- [PATCH v5 01/20] scripts/clean-includes: Fully skip / ignore files, Markus Armbruster, 2023/01/30
- [PATCH v5 09/20] hw/tricore: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 14/20] riscv: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 03/20] scripts/clean-includes: Skip symbolic links, Markus Armbruster, 2023/01/30
- [PATCH v5 16/20] accel: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 06/20] crypto: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 20/20] Drop duplicate #include, Markus Armbruster, 2023/01/30
- [PATCH v5 18/20] Don't include headers already included by qemu/osdep.h, Markus Armbruster, 2023/01/30
- [PATCH v5 15/20] block: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 11/20] migration: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 10/20] qga: Clean up includes,
Markus Armbruster <=
- [PATCH v5 02/20] scripts/clean-includes: Don't claim duplicate headers found when not, Markus Armbruster, 2023/01/30
- [PATCH v5 12/20] net: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 13/20] target/hexagon: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 05/20] bsd-user: Clean up includes, Markus Armbruster, 2023/01/30
- [PATCH v5 17/20] Fix non-first inclusions of qemu/osdep.h, Markus Armbruster, 2023/01/30
- [PATCH v5 19/20] 9p: Drop superfluous include of linux/limits.h, Markus Armbruster, 2023/01/30