Re: [PATCH v2 1/2] target/arm: implement DBGCLAIM registers

[Evgeny Iakovlev]

On 1/17/2023 16:48, Richard Henderson wrote:
> On 1/17/23 05:04, Evgeny Iakovlev wrote:
> > +    { .name = "DBGCLAIMCLR_EL1", .state = ARM_CP_STATE_BOTH,
> > +      .cp = 14, .opc0 = 2, .opc1 = 0, .crn = 7, .crm = 9, .opc2 = 6,
> > +      .access = PL1_RW, .accessfn = access_tda,
> > +      .writefn = dbgclaimclr_write, .raw_writefn = 
> > dbgclaimclr_raw_write,
> > +      .fieldoffset = offsetof(CPUARMState, cp15.dbgclaim) },
>
> You didn't need a new function, just .raw_writefn = raw_write
> (which then uses .fieldoffset to dtrt).


Ah, i see, okay.


> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
>
> r~