Re: [PATCH for-8.0 00/19] Convert most CPU classes to 3-phase reset

[Philippe Mathieu-Daudé]

On 30/11/22 13:38, Peter Maydell wrote:
> On Wed, 30 Nov 2022 at 10:51, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> > On 24/11/22 14:46, Philippe Mathieu-Daudé wrote:
> > > On 24/11/22 12:50, Peter Maydell wrote:
> > > > This patchset converts the TYPE_CPU base class and most subclasses
> > > > to use 3-phase reset. (The exception is s390, which is doing
> > > > something a bit odd with its reset, so the conversion there isn't
> > > > going to be simple like these others. So I'll do that one
> > > > separately.)
> > Note, we can then remove scripts/coccinelle/cpu-reset.cocci.
>
> What's our usual practice for out-of-date conversion coccinelle
> scripts? That particular script was "we'll never need this again"
> pretty much from the moment it was checked in, because we did
> the conversion of all the targets in one go. But it's still
> useful in some sense as a "this is an example of how to do
> this kind of change with a coccinelle script"...

The pattern I observed last years is:

 (a) If one-shot transformation, log the script in the commit
     description,

 (b) If the script can be used again in the future, commit it
     in scripts/coccinelle/,

 (c) Complex scripts are committed in scripts/coccinelle/ as
     example/reference.

I am fine keeping scripts/coccinelle/cpu-reset.cocci as an
example (c).

Regards,

Phil.