[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/2] hw/intc: add implementation of GICD_IIDR to Arm GIC
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v1 2/2] hw/intc: add implementation of GICD_IIDR to Arm GIC |
|
Date: |
Tue, 15 Nov 2022 14:04:22 +0000 |
On Tue, 15 Nov 2022 at 13:40, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> a66a24585f (hw/intc/arm_gic: Implement read of GICC_IIDR) implemented
> this for the CPU interface register. The fact we don't implement it
> shows up when running Xen with -d guest_error which is definitely
> wrong because the guest is perfectly entitled to read it.
>
> Lightly re-factor this region of registers and also add a comment to
> the function in case anyway was under the illusion we only return
> bytes from a function called readb.
This bit of the commit message hasn't been updated since v1 :-)
-- PMM