Re: [PATCH 1/8] hmat acpi: Don't require initiator value in -numa

[Hesham Almatary]

On 7/18/2022 2:54 PM, Igor Mammedov wrote:
> On Mon, 11 Jul 2022 11:44:29 +0100
> Hesham Almatary <hesham.almatary@huawei.com> wrote:
>
> > From: Brice Goglin <Brice.Goglin@inria.fr>
> >
> > The "Memory Proximity Domain Attributes" structure of the ACPI HMAT
> > has a "Processor Proximity Domain Valid" flag that is currently
> > always set because Qemu -numa requires an initiator=X value
> > when hmat=on. Unsetting this flag allows to create more complex
> > memory topologies by having multiple best initiators for a single
> > memory target.
> >
> > This patch allows -numa without initiator=X when hmat=on by keeping
> > the default value MAX_NODES in numa_state->nodes[i].initiator.
> > All places reading numa_state->nodes[i].initiator already check
> > whether it's different from MAX_NODES before using it.
> [...]
> > Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
> when re-posting patches from someone else, I think one is supposed to add
> his/her own SoB at the end
Sure, I can do that in v2. I wasn't sure as I haven't modified any of these 
patches.
> > ---
> >   hw/core/machine.c | 4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/hw/core/machine.c b/hw/core/machine.c
> > index a673302cce..d4d7e77401 100644
> > --- a/hw/core/machine.c
> > +++ b/hw/core/machine.c
> > @@ -1173,9 +1173,7 @@ static void numa_validate_initiator(NumaState *numa_state)
> >   
> >       for (i = 0; i < numa_state->num_nodes; i++) {
> >           if (numa_info[i].initiator == MAX_NODES) {
> > -            error_report("The initiator of NUMA node %d is missing, use "
> > -                         "'-numa node,initiator' option to declare it", i);
> > -            exit(1);
> > +            continue;
> >           }
> >   
> >           if (!numa_info[numa_info[i].initiator].present) {