Re: [PATCH 1/3] aspeed/scu: Add trace events for read ops

[Peter Delevoryas]

> On Jun 28, 2022, at 8:47 AM, Cédric Le Goater <clg@kaod.org> wrote:
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>

Also a nice change.

Reviewed-by: Peter Delevoryas <pdel@fb.com>

> ---
> hw/misc/aspeed_scu.c | 2 ++
> hw/misc/trace-events | 1 +
> 2 files changed, 3 insertions(+)
> 
> diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c
> index 19b03471fc4e..83353649064a 100644
> --- a/hw/misc/aspeed_scu.c
> +++ b/hw/misc/aspeed_scu.c
> @@ -270,6 +270,7 @@ static uint64_t aspeed_scu_read(void *opaque, hwaddr 
> offset, unsigned size)
>         break;
>     }
> 
> +    trace_aspeed_scu_read(offset, size, s->regs[reg]);
>     return s->regs[reg];
> }
> 
> @@ -637,6 +638,7 @@ static uint64_t aspeed_ast2600_scu_read(void *opaque, 
> hwaddr offset,
>         break;
>     }
> 
> +    trace_aspeed_scu_read(offset, size, s->regs[reg]);
>     return s->regs[reg];
> }
> 
> diff --git a/hw/misc/trace-events b/hw/misc/trace-events
> index c5e37b01547f..f776f24fb5d1 100644
> --- a/hw/misc/trace-events
> +++ b/hw/misc/trace-events
> @@ -69,6 +69,7 @@ slavio_led_mem_readw(uint32_t ret) "Read diagnostic LED 
> 0x%04x"
> 
> # aspeed_scu.c
> aspeed_scu_write(uint64_t offset, unsigned size, uint32_t data) "To 0x%" 
> PRIx64 " of size %u: 0x%" PRIx32
> +aspeed_scu_read(uint64_t offset, unsigned size, uint32_t data) "To 0x%" 
> PRIx64 " of size %u: 0x%" PRIx32
> 
> # mps2-scc.c
> mps2_scc_read(uint64_t offset, uint64_t data, unsigned size) "MPS2 SCC read: 
> offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u"
> -- 
> 2.35.3
> 
>