[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Trivial: 3 char repeat typos
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH] Trivial: 3 char repeat typos |
|
Date: |
Mon, 23 May 2022 11:34:41 +0100 |
On Mon, 23 May 2022 at 11:24, Dr. David Alan Gilbert
<dgilbert@redhat.com> wrote:
>
> * Peter Maydell (peter.maydell@linaro.org) wrote:
> > On Mon, 23 May 2022 at 11:09, Dr. David Alan Gilbert (git)
> > <dgilbert@redhat.com> wrote:
> > >
> > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > >
> > > Inspired by Julia Lawall's fixing of Linux
> > > kernel comments, I looked at qemu, although I did it manually.
> > >
> > > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >
> > Checkpatch would probably ask you to fix up some of the comment
> > styles when you touch some of these. Either way:
>
> The only one it actually moaned about was hw/pci/shpc.c's comment style.
> Does this need fixing in this patch?
Personally I would fix it, but I don't insist that you do
(hence "Either way").
-- PMM