[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 20/60] target/arm: Use smin/smax for do_sat_addsub_32
From: |
Richard Henderson |
Subject: |
[PATCH v3 20/60] target/arm: Use smin/smax for do_sat_addsub_32 |
Date: |
Sun, 17 Apr 2022 10:43:46 -0700 |
The operation we're performing with the movcond
is either min/max depending on cond -- simplify.
Use tcg_constant_i64 while we're at it.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/translate-sve.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index 2c23459e76..ddc3a8060b 100644
--- a/target/arm/translate-sve.c
+++ b/target/arm/translate-sve.c
@@ -1916,8 +1916,6 @@ static bool trans_PNEXT(DisasContext *s, arg_rr_esz *a)
static void do_sat_addsub_32(TCGv_i64 reg, TCGv_i64 val, bool u, bool d)
{
int64_t ibound;
- TCGv_i64 bound;
- TCGCond cond;
/* Use normal 64-bit arithmetic to detect 32-bit overflow. */
if (u) {
@@ -1928,15 +1926,12 @@ static void do_sat_addsub_32(TCGv_i64 reg, TCGv_i64
val, bool u, bool d)
if (d) {
tcg_gen_sub_i64(reg, reg, val);
ibound = (u ? 0 : INT32_MIN);
- cond = TCG_COND_LT;
+ tcg_gen_smax_i64(reg, reg, tcg_constant_i64(ibound));
} else {
tcg_gen_add_i64(reg, reg, val);
ibound = (u ? UINT32_MAX : INT32_MAX);
- cond = TCG_COND_GT;
+ tcg_gen_smin_i64(reg, reg, tcg_constant_i64(ibound));
}
- bound = tcg_const_i64(ibound);
- tcg_gen_movcond_i64(cond, reg, reg, bound, bound, reg);
- tcg_temp_free_i64(bound);
}
/* Similarly with 64-bit values. */
--
2.25.1
- [PATCH v3 11/60] target/arm: Split out set_btype_raw, (continued)
- [PATCH v3 11/60] target/arm: Split out set_btype_raw, Richard Henderson, 2022/04/17
- [PATCH v3 14/60] target/arm: Simplify GEN_SHIFT in translate.c, Richard Henderson, 2022/04/17
- [PATCH v3 10/60] target/arm: Remove fpexc32_access, Richard Henderson, 2022/04/17
- [PATCH v3 12/60] target/arm: Split out gen_rebuild_hflags, Richard Henderson, 2022/04/17
- [PATCH v3 13/60] target/arm: Use tcg_constant in translate-a64.c, Richard Henderson, 2022/04/17
- [PATCH v3 20/60] target/arm: Use smin/smax for do_sat_addsub_32,
Richard Henderson <=
- [PATCH v3 22/60] target/arm: Use tcg_constant in translate-vfp.c, Richard Henderson, 2022/04/17
- [PATCH v3 29/60] target/arm: Change cpreg access permissions to enum, Richard Henderson, 2022/04/17
- [PATCH v3 21/60] target/arm: Use tcg_constant in translate-sve.c, Richard Henderson, 2022/04/17
- [PATCH v3 25/60] target/arm: Reorg CPAccessResult and access_check_cp_reg, Richard Henderson, 2022/04/17