Re: [PATCH for-7.0] hw/intc/arm_gicv3_its: Add missing newlines to process_mapc() logging

[Richard Henderson]

On 3/22/22 03:38, Philippe Mathieu-Daudé wrote:
> On 22/3/22 11:28, Peter Maydell wrote:
> > In commit 84d43d2e82da we rearranged the logging of errors in
> > process_mapc(), and inadvertently dropped the trailing newlines
> > from the log messages. Restore them.
> >
> > Fixes: 84d43d2e82da ("hw/intc/arm_gicv3_its: In MAPC with V=0, don't check rdbase 
> > field")
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> >   hw/intc/arm_gicv3_its.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c
> > index b96b874afdf..d9c741f5fdd 100644
> > --- a/hw/intc/arm_gicv3_its.c
> > +++ b/hw/intc/arm_gicv3_its.c
> > @@ -524,12 +524,12 @@ static ItsCmdResult process_mapc(GICv3ITSState *s, const uint64_t 
> > *cmdpkt)
> >       trace_gicv3_its_cmd_mapc(icid, cte.rdbase, cte.valid);
> >       if (icid >= s->ct.num_entries) {
> > -        qemu_log_mask(LOG_GUEST_ERROR, "ITS MAPC: invalid ICID 0x%d", icid);
> > +        qemu_log_mask(LOG_GUEST_ERROR, "ITS MAPC: invalid ICID 0x%d\n", icid);
>
> (pre-existing: "%u" format, since icid is uint32_t)

Worse than that: 0x%d is going to be *very* misleading.
Should fix to 0x%x right away.


r~