qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/9] hw/i2c: pmbus: add PEC unsupported warning


From: Titus Rwantare
Subject: Re: [PATCH v3 3/9] hw/i2c: pmbus: add PEC unsupported warning
Date: Mon, 7 Mar 2022 11:31:00 -0800

Yes, fixed.

On Fri, 4 Mar 2022 at 16:02, Philippe Mathieu-Daudé
<philippe.mathieu.daude@gmail.com> wrote:
>
> On 2/3/22 02:50, Titus Rwantare wrote:
> > Signed-off-by: Titus Rwantare <titusr@google.com>
> > ---
> >   hw/i2c/pmbus_device.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
> > index 93c746bab3..6eeb0731d7 100644
> > --- a/hw/i2c/pmbus_device.c
> > +++ b/hw/i2c/pmbus_device.c
> > @@ -307,6 +307,11 @@ static uint8_t pmbus_receive_byte(SMBusDevice *smd)
> >
> >       case PMBUS_CAPABILITY:
> >           pmbus_send8(pmdev, pmdev->capability);
> > +        if (pmdev->capability & BIT(7)) {
> > +            qemu_log_mask(LOG_GUEST_ERROR,
>
> That would be LOG_UNIMP?
>
> > +                          "%s: PEC is enabled but not yet supported.\n",
> > +                          __func__);
> > +        }
> >           break;
> >
> >       case PMBUS_VOUT_MODE:                 /* R/W byte */
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]