[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/arm/virt: Validate memory size on the first NUMA node
|
From: |
Laszlo Ersek |
|
Subject: |
Re: [PATCH] hw/arm/virt: Validate memory size on the first NUMA node |
|
Date: |
Fri, 4 Mar 2022 15:24:30 +0100 |
Gerd,
On 03/04/22 11:58, Peter Maydell wrote:
> On Fri, 4 Mar 2022 at 10:52, Igor Mammedov <imammedo@redhat.com> wrote:
>> if firmware is not an option, I wouldn't opposed to printing warning
>> message from QEMU if you can detect that you are running broken edk2
>> and under condition that no new infa/hooks are invented for this.
>> (assuming it's worth all the effort at all)
>
> I am definitely not in favour of that. QEMU should provide the
> emulated hardware and let the firmware deal with detecting if
> it's missing important stuff. It should as far as is possible
> not have special-case detection-of-broken-guests handling.
>
> thanks
> -- PMM
>
It's probably simplest if you replace the ASSERT()s in question; please
see the attachment. (Only smoke tested.) Gavin indicated up-thread he'd
be OK with an easier-to-understand error message.
Laszlo
0001-ArmVirtPkg-QemuVirtMemInfoLib-improve-error-messages-for-MemoryInitPei.patch
Description: Text Data