qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM p


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path
Date: Tue, 22 Feb 2022 16:47:42 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.0

On 22/2/22 16:04, Markus Armbruster wrote:
Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> writes:

Hi Markus,

On 22/2/22 13:02, Markus Armbruster wrote:
Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and
the RTC supports the event).  What if there's more than one RTC?

w.r.t. RTC, a machine having multiple RTC devices is silly...

Assuming one wants to emulate that; shouldn't all QMP events have a
qom-path by default? Or have a generic "event-from-multiple-sources"
flag which automatically add this field?

Not all events originate from a device, or even a QOM object.

OK.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

The ones that do could all use a qom-path member, I guess.

[...]




reply via email to

[Prev in Thread] Current Thread [Next in Thread]