Re: [PATCH v3 1/2] hvf: arm: Use macros for sysreg shift/masking

[Peter Maydell]

On Wed, 9 Feb 2022 at 12:41, Alexander Graf <agraf@csgraf.de> wrote:
>
> We are parsing the syndrome field for sysregs in multiple places across
> the hvf code, but repeat shift/mask operations with hard coded constants
> every time. This is an error prone approach and makes it harder to reason
> about the correctness of these operations.
>
> Let's introduce macros that allow us to unify the constants used as well
> as create new helpers to extract fields from the sysreg value.
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Alexander Graf <agraf@csgraf.de>

Applied this and patch 2/2 to target-arm.next, thanks.

(If you can send multi-patch sets with a cover letter that helps the
automated tools, by the way.)

-- PMM