Re: [PATCH 3/6] aspeed: rainier: Add i2c LED devices

[Philippe Mathieu-Daudé]

On 16/2/22 10:21, Cédric Le Goater wrote:
> From: Joel Stanley <joel@jms.id.au>
>
> This helps quieten booting the current Rainier kernel.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   hw/arm/aspeed.c | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
>
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index 9789a489047b..0e5e5c31d59c 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -723,6 +723,8 @@ static void rainier_bmc_i2c_init(AspeedMachineState *bmc)
>   
>       aspeed_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 0), 0x51, 32 * KiB);
>   
> +    i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 3), "pca9552", 0x61);

Possible cleanup: add a create_pca9552(soc, i2c_bus_id, i2c_addr) static
helper which uses the TYPE_PCA9552 definitions.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>