On Sun, 6 Feb 2022 at 01:41, Patrick Venture <venture@google.com> wrote:
>
> From: Shengtan Mao <stmao@google.com>
>
> Reviewed-by: Hao Wu <wuhaotsh@google.com>
> Reviewed-by: Chris Rauer <crauer@google.com>
> Signed-off-by: Shengtan Mao <stmao@google.com>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
> v2:
> * update copyright year
> * check result of open
> * use g_free instead of free
> * move declarations to the top
> * use g_file_open_tmp
Fails to compile:
../../tests/qtest/npcm7xx_sdhci-test.c:121:32: error: use of
undeclared identifier 'NPCM7XX_REG_SIZE'
uint64_t end_addr = addr + NPCM7XX_REG_SIZE;
^
Thanks. I must have only compiled at a part-way point while tweaking it. I'll see if it compiles for me, and then figure out why it does when it doesn't, or if it doesn't, then obviously fix it. Either way, will fix in v3, thanks.
-- PMM