[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [RFC PATCH 0/4] improve coverage of vector backend
From: |
Taylor Simpson |
Subject: |
RE: [RFC PATCH 0/4] improve coverage of vector backend |
Date: |
Thu, 3 Feb 2022 19:01:54 +0000 |
> -----Original Message-----
> From: Alex Bennée <alex.bennee@linaro.org>
> Sent: Thursday, February 3, 2022 12:26 PM
> To: Taylor Simpson <tsimpson@quicinc.com>
> Cc: richard.henderson@linaro.org; qemu-devel@nongnu.org; qemu-
> arm@nongnu.org; fam@euphon.net; berrange@redhat.com;
> f4bug@amsat.org; aurelien@aurel32.net; pbonzini@redhat.com;
> stefanha@redhat.com; crosa@redhat.com
> Subject: Re: [RFC PATCH 0/4] improve coverage of vector backend
>
> > Any chance the problem is in the test itself (e.g., some sort of
> > undefined behavior or a 64-bit vs 32-bit difference)?
>
> It does have a 64 bit byteswap in - it's possible I broke it copying from the
> upstream:
>
> https://ccodearchive.net/info/crypto/sha512.html
>
> but it does pass on *all* the other architectures which is a mix of 32 and 64
> bit code. I did have to hack the endian detection code though.
> Does:
>
> #if BYTE_ORDER == BIG_ENDIAN
>
> work for your compiler?
No, but this does
#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
With that change in the source, the tests passes. Will that work for other
targets?
Taylor
- [RFC PATCH 3/4] tests/tcg: add sha512 test, (continued)
- [RFC PATCH 3/4] tests/tcg: add sha512 test, Alex Bennée, 2022/02/02
- [RFC PATCH 4/4] tests/tcg: add vectorised sha512 versions, Alex Bennée, 2022/02/02
- Re: [RFC PATCH 0/4] improve coverage of vector backend, Alex Bennée, 2022/02/02
- RE: [RFC PATCH 0/4] improve coverage of vector backend, Taylor Simpson, 2022/02/02
- RE: [RFC PATCH 0/4] improve coverage of vector backend, Taylor Simpson, 2022/02/03
- Re: [RFC PATCH 0/4] improve coverage of vector backend, Alex Bennée, 2022/02/03
- RE: [RFC PATCH 0/4] improve coverage of vector backend, Taylor Simpson, 2022/02/03
- Re: [RFC PATCH 0/4] improve coverage of vector backend, Alex Bennée, 2022/02/03
- RE: [RFC PATCH 0/4] improve coverage of vector backend,
Taylor Simpson <=
- Re: [RFC PATCH 0/4] improve coverage of vector backend, Alex Bennée, 2022/02/03
- RE: [RFC PATCH 0/4] improve coverage of vector backend, Taylor Simpson, 2022/02/03
- Re: [RFC PATCH 0/4] improve coverage of vector backend, Richard Henderson, 2022/02/03