Re: [PATCH 2/3] tests/qtest: add tests for MAX31790 fan controller

[Peter Maydell]

On Wed, 12 Jan 2022 at 00:25, Titus Rwantare <titusr@google.com> wrote:
>
> Signed-off-by: Titus Rwantare <titusr@google.com>
> Reviewed-by: Hao Wu <wuhaotsh@google.com>
> ---
>  tests/qtest/max31790_fan_ctrl-test.c | 171 +++++++++++++++++++++++++++
>  tests/qtest/meson.build              |   1 +
>  2 files changed, 172 insertions(+)
>  create mode 100644 tests/qtest/max31790_fan_ctrl-test.c

Tests look OK to me, so
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Is it worth adding a test of the address auto-increment logic,
given that the 'increases modulo 8' behaviour is not completely
trivial ?

thanks
-- PMM