[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] hw/net: Move MV88W8618 network device out of hw/arm/
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 2/2] hw/net: Move MV88W8618 network device out of hw/arm/ directory |
|
Date: |
Sat, 18 Dec 2021 00:21:47 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
On 12/17/21 23:25, Richard Henderson wrote:
> On 12/16/21 4:56 AM, Philippe Mathieu-Daudé wrote:
>> +softmmu_ss.add(when: 'CONFIG_MUSICPAL', if_true:
>> files('mv88w8618_eth.c'))
>
> So... there's currently a MARVELL_88W8618 define for the audio component
> of the same chip. Should we re-use that here?
I missed that, good point.
>
> Otherwise,
> Acked-by: Richard Henderson <richard.henderson@linaro.org>
Thank you.