Re: [PATCH 2/2] hw/net: Move MV88W8618 network device out of hw/arm/ directory

[Philippe Mathieu-Daudé]

On 12/16/21 09:45, Philippe Mathieu-Daudé wrote:
> The Marvell 88W8618 network device is hidden in the Musicpal
> machine. Move it into a new unit file under the hw/net/ directory.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  include/hw/net/mv88w8618_eth.h |  16 ++
>  hw/arm/musicpal.c              | 380 +-----------------------------
>  hw/net/mv88w8618_eth.c         | 406 +++++++++++++++++++++++++++++++++
>  MAINTAINERS                    |   2 +
>  hw/net/meson.build             |   1 +
>  5 files changed, 426 insertions(+), 379 deletions(-)
>  create mode 100644 include/hw/net/mv88w8618_eth.h
>  create mode 100644 hw/net/mv88w8618_eth.c
> 
> diff --git a/include/hw/net/mv88w8618_eth.h b/include/hw/net/mv88w8618_eth.h
> new file mode 100644
> index 00000000000..65e880e0eb7
> --- /dev/null
> +++ b/include/hw/net/mv88w8618_eth.h
> @@ -0,0 +1,16 @@
> +/*
> + * Marvell MV88W8618 / Freecom MusicPal emulation.
> + *
> + * Copyright (c) 2008 Jan Kiszka
> + *
> + * This code is licensed under the GNU GPL v2.
> + *
> + * Contributions after 2012-01-13 are licensed under the terms of the
> + * GNU GPL, version 2 or (at your option) any later version.

These 2 lines are probably irrelevant here.

> + */
> +#ifndef HW_NET_MV88W8618_H
> +#define HW_NET_MV88W8618_H
> +
> +#define TYPE_MV88W8618_ETH "mv88w8618_eth"
> +
> +#endif