Re: [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process

qemu-arm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process_its

From:	Richard Henderson
Subject:	Re: [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd()
Date:	Sun, 12 Dec 2021 14:02:25 -0800
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 12/11/21 11:11 AM, Peter Maydell wrote:

Fix process_its_cmd() to consistently return CMD_STALL for
memory errors and CMD_CONTINUE for parameter errors, as
we claim in the comments that we do.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 11/26] hw/intc/arm_gicv3_its: Use 1ULL when shifting by (DTE.SIZE + 1), (continued)
- [PATCH 13/26] hw/intc/arm_gicv3_its: Use FIELD macros for CTEs, Peter Maydell, 2021/12/11
  - Re: [PATCH 13/26] hw/intc/arm_gicv3_its: Use FIELD macros for CTEs, Richard Henderson, 2021/12/12
  - Re: [PATCH 13/26] hw/intc/arm_gicv3_its: Use FIELD macros for CTEs, Alex Bennée, 2021/12/13
- [PATCH 09/26] hw/intc/arm_gicv3_its: Correct handling of MAPI, Peter Maydell, 2021/12/11
  - Re: [PATCH 09/26] hw/intc/arm_gicv3_its: Correct handling of MAPI, Richard Henderson, 2021/12/12
  - Re: [PATCH 09/26] hw/intc/arm_gicv3_its: Correct handling of MAPI, Alex Bennée, 2021/12/13
- [PATCH 17/26] hw/intc/arm_gicv3_its: Convert int ID check to num_intids convention, Peter Maydell, 2021/12/11
  - Re: [PATCH 17/26] hw/intc/arm_gicv3_its: Convert int ID check to num_intids convention, Alex Bennée, 2021/12/13
- [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd(), Peter Maydell, 2021/12/11
  - Re: [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd(), Richard Henderson <=
  - Re: [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd(), Alex Bennée, 2021/12/13
- [PATCH 08/26] hw/intc/arm_gicv3_its: Don't misuse GITS_TYPE_PHYSICAL define, Peter Maydell, 2021/12/11
  - Re: [PATCH 08/26] hw/intc/arm_gicv3_its: Don't misuse GITS_TYPE_PHYSICAL define, Richard Henderson, 2021/12/12
  - Re: [PATCH 08/26] hw/intc/arm_gicv3_its: Don't misuse GITS_TYPE_PHYSICAL define, Alex Bennée, 2021/12/13
- [PATCH 20/26] hw/intc/arm_gicv3_its: Use enum for return value of process_* functions, Peter Maydell, 2021/12/11
  - Re: [PATCH 20/26] hw/intc/arm_gicv3_its: Use enum for return value of process_* functions, Richard Henderson, 2021/12/12
  - Re: [PATCH 20/26] hw/intc/arm_gicv3_its: Use enum for return value of process_* functions, Philippe Mathieu-Daudé, 2021/12/13
  - Re: [PATCH 20/26] hw/intc/arm_gicv3_its: Use enum for return value of process_* functions, Alex Bennée, 2021/12/13
- [PATCH 26/26] hw/intc/arm_gicv3_its: Factor out "find address of table entry" code, Peter Maydell, 2021/12/11
  - Re: [PATCH 26/26] hw/intc/arm_gicv3_its: Factor out "find address of table entry" code, Richard Henderson, 2021/12/12

Prev by Date: Re: [PATCH 10/26] hw/intc/arm_gicv3_its: Use FIELD macros for DTEs
Next by Date: Re: [PATCH 22/26] hw/intc/arm_gicv3_its: Refactor process_its_cmd() to reduce nesting
Previous by thread: [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd()
Next by thread: Re: [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd()
Index(es):
- Date
- Thread