[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/26] hw/intc: clean-up error reporting for failed ITS cmd

From: Richard Henderson
Subject: Re: [PATCH 01/26] hw/intc: clean-up error reporting for failed ITS cmd
Date: Sun, 12 Dec 2021 09:31:37 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 12/11/21 11:11 AM, Peter Maydell wrote:
From: Alex Bennée<alex.bennee@linaro.org>

While trying to debug a GIC ITS failure I saw some guest errors that
had poor formatting as well as leaving me confused as to what failed.
As most of the checks aren't possible without a valid dte split that
check apart and then check the other conditions in steps. This avoids
us relying on undefined data.

I still get a failure with the current kvm-unit-tests but at least I
know (partially) why now:

   Exception return from AArch64 EL1 to AArch64 EL1 PC 0x40080588
   PASS: gicv3: its-trigger: inv/invall: dev2/eventid=20 now triggers an LPI
   ITS: MAPD devid=2 size = 0x8 itt=0x40430000 valid=0
   INT dev_id=2 event_id=20
   process_its_cmd: invalid command attributes: invalid dte: 0 for 2 (MEM_TX: 0)
   PASS: gicv3: its-trigger: mapd valid=false: no LPI after device unmap
   SUMMARY: 6 tests, 1 unexpected failures

Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
Cc: Shashi Mallela<shashi.mallela@linaro.org>
Cc: Peter Maydell<peter.maydell@linaro.org>
Reviewed-by: Peter Maydell<peter.maydell@linaro.org>
Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
  hw/intc/arm_gicv3_its.c | 39 +++++++++++++++++++++++++++------------
  1 file changed, 27 insertions(+), 12 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]