[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/2] hw/arm/virt: Support for virtio-mem-pci

From: Gavin Shan
Subject: Re: [PATCH v2 1/2] hw/arm/virt: Support for virtio-mem-pci
Date: Sat, 4 Dec 2021 10:23:08 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0

On 12/4/21 5:18 AM, David Hildenbrand wrote:
On 03.12.21 04:35, Gavin Shan wrote:
This supports virtio-mem-pci device on "virt" platform, by simply
following the implementation on x86.

    * This implements the hotplug handlers to support virtio-mem-pci
      device hot-add, while the hot-remove isn't supported as we have
      on x86.

    * The block size is 512MB on ARM64 instead of 128MB on x86.

    * It has been passing the tests with various combinations like 64KB
      and 4KB page sizes on host and guest, different memory device
      backends like normal, transparent huge page and HugeTLB, plus

I would turn this patch into 2/2, reshuffling both patches.

Co-developed-by: David Hildenbrand <david@redhat.com>
Co-developed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Gavin Shan <gshan@redhat.com>

Reviewed-by: David Hildenbrand <david@redhat.com>

Thanks Gavin!

Yup, I thought of it. The fixed issue doesn't exist if virtio-mem
isn't enabled on ARM64 with PATCH[1/2]. That's why I have this
patch as PATCH[2/2]. However, It's also sensible to me to reshuffle
the patches: to eliminate potential issues before enabling virtio-mem
on ARM64. v3 will have the changes :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]