qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-7.0 3/4] target/rx/cpu.h: Don't include qemu-common.h


From: Yoshinori Sato
Subject: Re: [PATCH for-7.0 3/4] target/rx/cpu.h: Don't include qemu-common.h
Date: Wed, 01 Dec 2021 21:26:22 +0900
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (Goj┼Ź) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

On Tue, 30 Nov 2021 05:05:09 +0900,
Peter Maydell wrote:
> 
> The qemu-common.h header is not supposed to be included from any
> other header files, only from .c files (as documented in a comment at
> the start of it).
> 
> Nothing actually relies on target/rx/cpu.h including it, so we can
> just drop the include.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>

> ---
>  target/rx/cpu.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/rx/cpu.h b/target/rx/cpu.h
> index 4ac71aec370..657db84ef0a 100644
> --- a/target/rx/cpu.h
> +++ b/target/rx/cpu.h
> @@ -20,7 +20,6 @@
>  #define RX_CPU_H
>  
>  #include "qemu/bitops.h"
> -#include "qemu-common.h"
>  #include "hw/registerfields.h"
>  #include "cpu-qom.h"
>  
> -- 
> 2.25.1
> 
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]