[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-7.0 1/4] include/hw/i386: Don't include qemu-common.h in .h f
From: |
Peter Maydell |
Subject: |
[PATCH for-7.0 1/4] include/hw/i386: Don't include qemu-common.h in .h files |
Date: |
Mon, 29 Nov 2021 20:05:07 +0000 |
The qemu-common.h header is not supposed to be included from any
other header files, only from .c files (as documented in a comment at
the start of it).
include/hw/i386/x86.h and include/hw/i386/microvm.h break this rule.
In fact, the include is not required at all, so we can just drop it
from both files.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
include/hw/i386/microvm.h | 1 -
include/hw/i386/x86.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h
index 4d9c732d4b2..efcbd926fd4 100644
--- a/include/hw/i386/microvm.h
+++ b/include/hw/i386/microvm.h
@@ -18,7 +18,6 @@
#ifndef HW_I386_MICROVM_H
#define HW_I386_MICROVM_H
-#include "qemu-common.h"
#include "exec/hwaddr.h"
#include "qemu/notify.h"
diff --git a/include/hw/i386/x86.h b/include/hw/i386/x86.h
index bb1cfb88966..a145a303703 100644
--- a/include/hw/i386/x86.h
+++ b/include/hw/i386/x86.h
@@ -17,7 +17,6 @@
#ifndef HW_I386_X86_H
#define HW_I386_X86_H
-#include "qemu-common.h"
#include "exec/hwaddr.h"
#include "qemu/notify.h"
--
2.25.1
- [PATCH for-7.0 0/4] qemu-common.h include cleanup, Peter Maydell, 2021/11/29
- [PATCH for-7.0 3/4] target/rx/cpu.h: Don't include qemu-common.h, Peter Maydell, 2021/11/29
- [PATCH for-7.0 4/4] hw/arm: Don't include qemu-common.h unnecessarily, Peter Maydell, 2021/11/29
- [PATCH for-7.0 1/4] include/hw/i386: Don't include qemu-common.h in .h files,
Peter Maydell <=
- [PATCH for-7.0 2/4] target/hexagon/cpu.h: don't include qemu-common.h, Peter Maydell, 2021/11/29
- Re: [PATCH for-7.0 0/4] qemu-common.h include cleanup, Peter Maydell, 2021/11/29
- Re: [PATCH for-7.0 0/4] qemu-common.h include cleanup, Richard Henderson, 2021/11/30