[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [kvm-unit-tests PATCH v8 01/10] docs: mention checkpatch in the READ
From: |
Andrew Jones |
Subject: |
Re: [kvm-unit-tests PATCH v8 01/10] docs: mention checkpatch in the README |
Date: |
Wed, 24 Nov 2021 12:08:24 +0100 |
On Wed, Nov 24, 2021 at 12:07:02PM +0100, Andrew Jones wrote:
> On Thu, Nov 18, 2021 at 06:46:41PM +0000, Alex Bennée wrote:
> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > ---
> > README.md | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/README.md b/README.md
> > index b498aaf..5db48e5 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -182,3 +182,5 @@ the code files. We also start with common code and
> > finish with unit test
> > code. git-diff's orderFile feature allows us to specify the order in a
> > file. The orderFile we use is `scripts/git.difforder`; adding the config
> > with `git config diff.orderFile scripts/git.difforder` enables it.
> > +
> > +Please run the kernel's ./scripts/checkpatch.pl on new patches
>
> This is a bit of a problem for kvm-unit-tests code which still has a mix
> of styles since it was originally written with a strange tab and space
> mixed style. If somebody is patching one of those files we've usually
> tried to maintain the original style rather than reformat the whole
> thing (in hindsight maybe we should have just reformatted). We're also
> more flexible with line length than Linux, although Linux now only warns
> for anything over 80 as long as it's under 100, which is probably good
> enough for us too. Anyway, let's see what Paolo and Thomas say. Personally
> I wouldn't mind adding this line to the documentation, so I'll ack it.
> Anyway, we can also ignore our own advise when it suits us :-)
>
> Acked-by: Andrew Jones <drjones@redhat.com>
>
Forgot to CC Thomas and Paolo, am now.
Thanks,
drew
- [kvm-unit-tests PATCH v8 00/10] MTTCG sanity tests for ARM, Alex Bennée, 2021/11/18
- [kvm-unit-tests PATCH v8 03/10] Makefile: add GNU global tags support, Alex Bennée, 2021/11/18
- [kvm-unit-tests PATCH v8 02/10] arm/flat.lds: don't drop debug during link, Alex Bennée, 2021/11/18
- [kvm-unit-tests PATCH v8 01/10] docs: mention checkpatch in the README, Alex Bennée, 2021/11/18
- [kvm-unit-tests PATCH v8 06/10] arm/tlbflush-code: TLB flush during code execution, Alex Bennée, 2021/11/18
- [kvm-unit-tests PATCH v8 04/10] run_tests.sh: add --config option for alt test set, Alex Bennée, 2021/11/18
- [kvm-unit-tests PATCH v8 07/10] arm/locking-tests: add comprehensive locking test, Alex Bennée, 2021/11/18
- [kvm-unit-tests PATCH v8 08/10] arm/barrier-litmus-tests: add simple mp and sal litmus tests, Alex Bennée, 2021/11/18
- [kvm-unit-tests PATCH v8 05/10] lib: add isaac prng library from CCAN, Alex Bennée, 2021/11/18
- [kvm-unit-tests PATCH v8 10/10] arm/tcg-test: some basic TCG exercising tests, Alex Bennée, 2021/11/18
- [kvm-unit-tests PATCH v8 09/10] arm/run: use separate --accel form, Alex Bennée, 2021/11/18