[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] raspi: Use error_fatal for SoC realize errors, not error
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 1/3] raspi: Use error_fatal for SoC realize errors, not error_abort |
Date: |
Mon, 16 Aug 2021 17:10:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/16/21 3:58 PM, Peter Maydell wrote:
> The SoC realize can fail for legitimate reasons, because it propagates
> errors up from CPU realize, which in turn can be provoked by user
> error in setting commandline options. Use error_fatal so we report
> the error message to the user and exit, rather than asserting
> via error_abort.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/arm/raspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH 0/3] arm: Avoid asserting in cpu_address_space_init(), Peter Maydell, 2021/08/16
- [PATCH 1/3] raspi: Use error_fatal for SoC realize errors, not error_abort, Peter Maydell, 2021/08/16
- Re: [PATCH 1/3] raspi: Use error_fatal for SoC realize errors, not error_abort,
Philippe Mathieu-Daudé <=
- [PATCH 2/3] target/arm: Avoid assertion trying to use KVM and multiple ASes, Peter Maydell, 2021/08/16
- [PATCH 3/3] hw/arm/virt: Delete EL3 error checksnow provided in CPU realize, Peter Maydell, 2021/08/16
- Re: [PATCH 0/3] arm: Avoid asserting in cpu_address_space_init(), Richard Henderson, 2021/08/16