Re: [PATCH for-6.2 51/53] target/arm: Implement MVE VCVT between single and half precision

[Richard Henderson]

On 7/29/21 1:15 AM, Peter Maydell wrote:
> +/*
> + * VCVT between halfprec and singleprec. As usual for halfprec
> + * conversions, FZ16 is ignored and AHP is observed.
> + */
> +#define DO_VCVT_SH(OP, TOP)                                             \
> +    void HELPER(glue(mve_, OP))(CPUARMState *env, void *vd, void *vm)   \

These might be easier to read as a local function with an extra "top" argument, rather 
than as a macro, since you're not passing in anything complicated.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~