Re: [PATCH 1/4] target-arm: Introduce ARM_FEATURE_A64FX

[Peter Maydell]

On Fri, 16 Jul 2021 at 06:27, Shuuichirou Ishii
<ishii.shuuichir@fujitsu.com> wrote:
>
> This function is used to distinguish HPC extensions in the Fujitsu A64FX 
> processor.
>
> HPC (High Performance Computing) extensions are A64FX processor-specific 
> features
> that are implemented to improve application performance for HPC.
>
> Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@fujitsu.com>
> ---
>  target/arm/cpu.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/target/arm/cpu.h b/target/arm/cpu.h
> index be9a4dc..e5c8645 100644
> --- a/target/arm/cpu.h
> +++ b/target/arm/cpu.h
> @@ -2140,6 +2140,7 @@ enum arm_features {
>      ARM_FEATURE_M_SECURITY, /* M profile Security Extension */
>      ARM_FEATURE_M_MAIN, /* M profile Main Extension */
>      ARM_FEATURE_V8_1M, /* M profile extras only in v8.1M and later */
> +    ARM_FEATURE_A64FX, /* Fujitsu A64FX processor HPC extensions support */
>  };

Hi; as far as I can see there's nothing in your patchset that ever
tests this feature bit and behaves differently as a result. We
shouldn't add the feature flag until we have something we want to
control with it.

thanks
-- PMM