[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.2 06/34] target/arm: Fix 48-bit saturating shifts
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH for-6.2 06/34] target/arm: Fix 48-bit saturating shifts |
|
Date: |
Fri, 16 Jul 2021 17:39:28 +0100 |
On Fri, 16 Jul 2021 at 17:34, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 7/13/21 6:36 AM, Peter Maydell wrote:
> > - return (1ULL << 47) - (src >= 0);
> > + return sextract64((1ULL << 47) - (src >= 0), 0, 48);
>
> Clearer as
>
> return src >= 0 ? MAKE_64BIT_MASK(0, 47) : MAKE_64BIT_MASK(47, 17);
Yeah, agreed.
thanks
-- PMM
- [PATCH for-6.2 01/34] target/arm: Note that we handle VMOVL as a special case of VSHLL, (continued)
- [PATCH for-6.2 01/34] target/arm: Note that we handle VMOVL as a special case of VSHLL, Peter Maydell, 2021/07/13
- [PATCH for-6.2 03/34] target/arm: Fix MVE VSLI by 0 and VSRI by <dt>, Peter Maydell, 2021/07/13
- [PATCH for-6.2 02/34] target/arm: Print MVE VPR in CPU dumps, Peter Maydell, 2021/07/13
- [PATCH for-6.2 04/34] target/arm: Fix signed VADDV, Peter Maydell, 2021/07/13
- [PATCH for-6.2 06/34] target/arm: Fix 48-bit saturating shifts, Peter Maydell, 2021/07/13
- [PATCH for-6.2 05/34] target/arm: Fix mask handling for MVE narrowing operations, Peter Maydell, 2021/07/13
- [PATCH for-6.2 09/34] target/arm: Factor out mve_eci_mask(), Peter Maydell, 2021/07/13
- [PATCH for-6.2 07/34] target/arm: Fix calculation of LTP mask when LR is 0, Peter Maydell, 2021/07/13
- [PATCH for-6.2 08/34] target/arm: Fix VPT advance when ECI is non-zero, Peter Maydell, 2021/07/13