[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 22/23] tests/acceptance/linux_ssh_mips_malta.py: drop identical se
From: |
Cleber Rosa |
Subject: |
[PULL 22/23] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp |
Date: |
Tue, 13 Jul 2021 17:19:22 -0400 |
These tests' setUp do not do anything beyong what their base class do.
And while they do decorate the setUp() we can decorate the classes
instead, so no functionality is lost here.
This is possible because since Avocado 76.0 we can decorate setUp()
directly.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210415215141.1865467-4-crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
[PMD: added note to commit message about Avocado feature/version]
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
tests/acceptance/linux_ssh_mips_malta.py | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/tests/acceptance/linux_ssh_mips_malta.py
b/tests/acceptance/linux_ssh_mips_malta.py
index 61c9079d04..4de1947418 100644
--- a/tests/acceptance/linux_ssh_mips_malta.py
+++ b/tests/acceptance/linux_ssh_mips_malta.py
@@ -19,6 +19,8 @@
from avocado.utils import ssh
+@skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
+@skipUnless(ssh.SSH_CLIENT_BINARY, 'No SSH client available')
class LinuxSSH(Test, LinuxSSHMixIn):
timeout = 150 # Not for 'configure --enable-debug --enable-debug-tcg'
@@ -65,11 +67,6 @@ def get_kernel_info(self, endianess, wordsize):
kernel_hash = self.IMAGE_INFO[endianess]['kernel_hash'][wordsize]
return kernel_url, kernel_hash
- @skipUnless(ssh.SSH_CLIENT_BINARY, 'No SSH client available')
- @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
- def setUp(self):
- super(LinuxSSH, self).setUp()
-
def ssh_disconnect_vm(self):
self.ssh_session.quit()
--
2.31.1
- [PULL 13/23] tests/acceptance: Automatic set -cpu to the test vm, (continued)
- [PULL 13/23] tests/acceptance: Automatic set -cpu to the test vm, Cleber Rosa, 2021/07/13
- [PULL 14/23] tests/acceptance: Fix mismatch on cpu tagged tests, Cleber Rosa, 2021/07/13
- [PULL 16/23] tests/acceptance: Tagging tests with "cpu:VALUE", Cleber Rosa, 2021/07/13
- [PULL 15/23] tests/acceptance: Let the framework handle "cpu:VALUE" tagged tests, Cleber Rosa, 2021/07/13
- [PULL 17/23] python/qemu: Add args property to the QEMUMachine class, Cleber Rosa, 2021/07/13
- [PULL 19/23] tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests, Cleber Rosa, 2021/07/13
- [PULL 18/23] tests/acceptance: Add set_vm_arg() to the Test class, Cleber Rosa, 2021/07/13
- [PULL 20/23] python: Configure tox to skip missing interpreters, Cleber Rosa, 2021/07/13
- [PULL 21/23] Acceptance tests: do not try to reuse packages from the system, Cleber Rosa, 2021/07/13
- [PULL 23/23] tests/acceptance/cpu_queries.py: use the proper logging channels, Cleber Rosa, 2021/07/13
- [PULL 22/23] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp,
Cleber Rosa <=
- Re: [PULL 00/23] Python and Acceptance Tests, Peter Maydell, 2021/07/14