[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/1] target/arm: Check NaN mode before silencing NaN
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 0/1] target/arm: Check NaN mode before silencing NaN |
|
Date: |
Mon, 28 Jun 2021 08:04:57 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 6/28/21 7:54 AM, Peter Maydell wrote:
Richard, Alex: what is the assertion trying to achieve ? It doesn't
seem entirely obvious to me that because we're in default-NaN mode
(which is a property of the *output* of FPU insns) that we should
blow up on calling float*_silence_nan() (which is typically an action
performed on the *input* of FPU insns).
This was in response to e9e5534ff30.
My assumption in adding the assert is that it was probably a configuration error. If you
disagree, I suppose we can revert it, as it's not critical.
If we do want to keep the assertion, somebody should audit the
other frontends that use float*_silence_nan() (i386, m68k, s390x)
to see if they also need updating.
Easily done. None of them ever set default_nan mode.
r~