[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/26] target/arm: Use translator_use_goto_tb
From: |
Peter Maydell |
Subject: |
Re: [PATCH 05/26] target/arm: Use translator_use_goto_tb |
Date: |
Mon, 21 Jun 2021 11:20:32 +0100 |
On Mon, 21 Jun 2021 at 02:42, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Put a wrapper in translate.h, which also checks for ss_active.
> The ss_active test was incorrectly missing from the a32 version.
True, but we almost never call gen_goto_tb() when ss_active
(which makes sense because we generate code to raise a singlestep
exception instead). The only cases I think where we do call
gen_goto_tb() are ISB and SB; everything else calls gen_jmp_tb()
or otherwise handles the is_singlestepping() case.
thanks
-- PMM