Re: [PATCH] target/arm: Provide and use H8 and H1_8 macros

[Philippe Mathieu-Daudé]

On 6/10/21 3:25 PM, Peter Maydell wrote:
> Currently we provide Hn and H1_n macros for accessing the correct
> data within arrays of vector elements of size 1, 2 and 4, accounting
> for host endianness.  We don't provide any macros for elements of
> size 8 because there the host endianness doesn't matter.  However,
> this does result in awkwardness where we need to pass empty arguments
> to macros, because checkpatch complains about them.  The empty
> argument is a little confusing for humans to read as well.
> 
> Add H8() and H1_8() macros and use them where we were previously
> passing empty arguments to macros.
> 
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This is a big patch but it was basically search-n-replaced
> (not entirely automatedly, but conveniently most of the SVE
> H1_8 locations were ",     ,").
> 
> SVE ZIP, UZP, TRN also have Int128 forms. I haven't attempted
> to provide macros for that case.
> ---
>  target/arm/vec_internal.h |   8 +-
>  target/arm/sve_helper.c   | 258 +++++++++++++++++++-------------------
>  target/arm/vec_helper.c   |  14 +--
>  3 files changed, 143 insertions(+), 137 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>