[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] aspeed: sonorapass: enable pca954x muxes
From: |
Joel Stanley |
Subject: |
Re: [PATCH 4/4] aspeed: sonorapass: enable pca954x muxes |
Date: |
Wed, 9 Jun 2021 01:58:21 +0000 |
On Tue, 8 Jun 2021 at 19:56, Patrick Venture <venture@google.com> wrote:
>
> On Wed, May 19, 2021 at 10:18 AM Patrick Venture <venture@google.com> wrote:
> >
> > On Tue, May 18, 2021 at 4:27 PM Joel Stanley <joel@jms.id.au> wrote:
> > >
> > > On Tue, 18 May 2021 at 19:41, Patrick Venture <venture@google.com> wrote:
> > > >
> > > > Enables the pca954x muxes in the bmc board configuration.
> > > >
> > > > Signed-off-by: Patrick Venture <venture@google.com>
> > > > Reviewed-by: Hao Wu <wuhaotsh@google.com>
> > >
> > > Not sure about this one, there's no device tree for it in Linux.
> >
> > Yeah, this was just a pick-up from grepping other BMC boards. I added
> > these going off the comment alone. I'd be okay with dropping this in
> > the series.
>
> In this case, the number of patches changed within a version change --
> should I start a fresh series or just bump the version and drop the
> last patch?
I wasn't saying we shouldn't include this change - it's good. I just
didn't have any information to say whether it was correct or not.
I see you chose to resend without this one, lets get Cedric to merge
those patches.
Cheers,
Joel