[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v16 02/99] accel: Introduce 'query-accels' QMP command
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v16 02/99] accel: Introduce 'query-accels' QMP command |
Date: |
Tue, 08 Jun 2021 17:41:57 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Alex Bennée <alex.bennee@linaro.org> writes:
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Introduce the 'query-accels' QMP command which returns a list
> of built-in accelerator names.
>
> - Accelerator is a QAPI enum of all existing accelerators,
>
> - AcceleratorInfo is a QAPI structure providing accelerator
> specific information. Currently the common structure base
> provides the name of the accelerator, while the specific
> part is empty, but each accelerator can expand it.
>
> - 'query-accels' QMP command returns a list of @AcceleratorInfo
>
> For example on a KVM-only build we get:
>
> { "execute": "query-accels" }
> {
> "return": [
> {
> "name": "qtest"
> },
> {
> "name": "kvm"
> }
> ]
> }
>
> Note that we can't make the enum values or union branches conditional
> because of target-specific poisoning of accelerator definitions.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Tested-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20210505125806.1263441-3-philmd@redhat.com>
I assume this one's superseded by Phil's "[PATCH v8 02/12] accel:
Introduce 'query-accels' QMP command", i.e. I should review that one,
not this one.
- [PATCH v16 00/99] arm tcg/kvm refactor and split with kvm only support, Alex Bennée, 2021/06/04
- [PATCH v16 01/99] MAINTAINERS: Add qtest/arm-cpu-features.c to ARM TCG CPUs section, Alex Bennée, 2021/06/04
- [PATCH v16 02/99] accel: Introduce 'query-accels' QMP command, Alex Bennée, 2021/06/04
- [PATCH v16 04/99] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM, Alex Bennée, 2021/06/04
- Re: [PATCH v16 04/99] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM, Richard Henderson, 2021/06/04
- Re: [PATCH v16 04/99] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM, Thomas Huth, 2021/06/07
- Re: [PATCH v16 04/99] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM, Philippe Mathieu-Daudé, 2021/06/08
- Re: [PATCH v16 04/99] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM, Philippe Mathieu-Daudé, 2021/06/08
- Re: [PATCH v16 04/99] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM, Philippe Mathieu-Daudé, 2021/06/08
- Re: [PATCH v16 04/99] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM, Eric Blake, 2021/06/08
- Re: [PATCH v16 04/99] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM, Claudio Fontana, 2021/06/08
[PATCH v16 05/99] qtest/arm-cpu-features: Restrict sve_tests_sve_off_kvm test to KVM, Alex Bennée, 2021/06/04