qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 02/12] accel: Introduce 'query-accels' QMP command


From: John Snow
Subject: Re: [PATCH v8 02/12] accel: Introduce 'query-accels' QMP command
Date: Wed, 2 Jun 2021 19:26:31 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1

On 5/26/21 1:04 PM, Philippe Mathieu-Daudé wrote:
Introduce the 'query-accels' QMP command which returns a list
of built-in accelerator names.
 > - Accelerator is a QAPI enum of all existing accelerators,

- AcceleratorInfo is a QAPI structure providing accelerator
   specific information. Currently the common structure base
   provides the name of the accelerator, while the specific
   part is empty, but each accelerator can expand it.

- 'query-accels' QMP command returns a list of @AcceleratorInfo

For example on a KVM-only build we get:

     { "execute": "query-accels" }
     {
         "return": [
             {
                 "name": "qtest"
             },
             {
                 "name": "kvm"
             }
         ]
     }

Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v8:
- Include code snippet from Markus adding to machine-target.json
   to be able to use enum values or union branches conditional.
- Use accel_find() on enum to be sure the accelerator is enabled
   at runtime (chat with jsnow / eblake).


Hi Phil -- Unfortunately I think I am going to defer on this one until Markus is back. I need to chat with him about the right way to design this, since I'm also not entirely clear on it myself.

--js

Cc: Eric Blake <eblake@redhat.com>
Cc: John Snow <jsnow@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]