[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 08/12] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 R
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 08/12] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC |
Date: |
Sat, 15 May 2021 19:37:12 +0200 |
Commit 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate
RTC with it") added a global dependency on the DS1338 model, instead
of a machine one (via Kconfig). This gives trouble when building
standalone machines not exposing I2C bus:
The following clauses were found for DS1338
CONFIG_DS1338=y
config DS1338 depends on I2C
Fix by selecting the DS1338 symbol in the single machine requiring
it, the E500.
Fixes: 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with
it")
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
default-configs/devices/ppc-softmmu.mak | 1 -
hw/ppc/Kconfig | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/default-configs/devices/ppc-softmmu.mak
b/default-configs/devices/ppc-softmmu.mak
index c2d41198cde..5a7f99d1e45 100644
--- a/default-configs/devices/ppc-softmmu.mak
+++ b/default-configs/devices/ppc-softmmu.mak
@@ -1,7 +1,6 @@
# Default configuration for ppc-softmmu
# For embedded PPCs:
-CONFIG_DS1338=y
CONFIG_E500=y
CONFIG_PPC405=y
CONFIG_PPC440=y
diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
index 66e0b15d9ef..2e4c56eb770 100644
--- a/hw/ppc/Kconfig
+++ b/hw/ppc/Kconfig
@@ -128,6 +128,7 @@ config E500
select SERIAL
select MPC_I2C
select FDT_PPC
+ select DS1338
config VIRTEX
bool
--
2.26.3
- [PATCH v2 02/12] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV, (continued)
- [PATCH v2 02/12] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV, Philippe Mathieu-Daudé, 2021/05/15
- [PATCH v2 03/12] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS, Philippe Mathieu-Daudé, 2021/05/15
- [PATCH v2 04/12] hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board, Philippe Mathieu-Daudé, 2021/05/15
- [PATCH v2 05/12] hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25, Philippe Mathieu-Daudé, 2021/05/15
- [PATCH v2 06/12] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL, Philippe Mathieu-Daudé, 2021/05/15
- [PATCH v2 07/12] hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines, Philippe Mathieu-Daudé, 2021/05/15
- [PATCH v2 08/12] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC,
Philippe Mathieu-Daudé <=
- [PATCH v2 09/12] hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259, Philippe Mathieu-Daudé, 2021/05/15
- [PATCH v2 10/12] hw/isa/vt82c686: Add missing Kconfig dependencies (build error), Philippe Mathieu-Daudé, 2021/05/15
- [PATCH v2 11/12] hw/isa/vt82c686: Add missing Kconfig dependency (runtime error), Philippe Mathieu-Daudé, 2021/05/15