Re: [PATCH v2 4/5] hw/misc: add MAX34451 device

[Joel Stanley]

On Wed, 5 May 2021 at 17:29, Titus Rwantare <titusr@google.com> wrote:
>
> The MAX34451 is a Maxim power-supply system manager that can monitor up to 16 
> voltage rails or currents. It also contains a temperature sensor and supports 
> up to four external temperature sensors.
>
> This commit adds support for interfacing with it, and setting limits on the 
> supported sensors.
>
> Reviewed-by: Hao Wu <wuhaotsh@google.com>
> Signed-off-by: Titus Rwantare <titusr@google.com>

Reviewed-by: Joel Stanley <joel@jms.id.au>


> +static void max34451_class_init(ObjectClass *klass, void *data)
> +{
> +    ResettableClass *rc = RESETTABLE_CLASS(klass);
> +    DeviceClass *dc = DEVICE_CLASS(klass);
> +    PMBusDeviceClass *k = PMBUS_DEVICE_CLASS(klass);
> +    dc->desc = "Maxim MAX34451 16-Channel V/I monitor";
> +    k->write_data = max34451_write_data;
> +    k->receive_byte = max34451_read_byte;
> +    k->device_num_pages = MAX34451_NUM_PAGES;
> +    /* k->quick_cmd */
> +    /* rc->phase.enter */
> +    /* rc->phases.hold */

These look like they can be removed.

> +    rc->phases.exit = max34451_exit_reset;
> +}