[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new() |
Date: |
Thu, 6 May 2021 15:37:53 +0200 |
The ALLOCA(3) man-page mentions its "use is discouraged".
Replace it by a g_new() call.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
bsd-user/syscall.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c
index 4abff796c76..dbee0385ceb 100644
--- a/bsd-user/syscall.c
+++ b/bsd-user/syscall.c
@@ -355,9 +355,8 @@ abi_long do_freebsd_syscall(void *cpu_env, int num,
abi_long arg1,
case TARGET_FREEBSD_NR_writev:
{
int count = arg3;
- struct iovec *vec;
+ g_autofree struct iovec *vec = g_new(struct iovec, count);
- vec = alloca(count * sizeof(struct iovec));
if (lock_iovec(VERIFY_READ, vec, arg2, count, 1) < 0)
goto efault;
ret = get_errno(writev(arg1, vec, count));
--
2.26.3
- [PATCH v2 0/9] misc: Replace alloca() by g_malloc(), Philippe Mathieu-Daudé, 2021/05/06
- [PATCH v2 1/9] audio/alsaaudio: Replace ALSA alloca() by malloc() equivalent, Philippe Mathieu-Daudé, 2021/05/06
- [PATCH v2 2/9] backends/tpm: Replace qemu_mutex_lock calls with QEMU_LOCK_GUARD, Philippe Mathieu-Daudé, 2021/05/06
- [PATCH v2 3/9] backends/tpm: Replace g_alloca() by g_malloc(), Philippe Mathieu-Daudé, 2021/05/06
- [PATCH v2 5/9] gdbstub: Constify GdbCmdParseEntry, Philippe Mathieu-Daudé, 2021/05/06
- [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(),
Philippe Mathieu-Daudé <=
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Warner Losh, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Peter Maydell, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Warner Losh, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Philippe Mathieu-Daudé, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Warner Losh, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Eric Blake, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Warner Losh, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Eric Blake, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Warner Losh, 2021/05/06
- Re: [PATCH v2 4/9] bsd-user/syscall: Replace alloca() by g_new(), Eric Blake, 2021/05/06