[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 11/12] qtest/bios-tables-test: Make test build-independent
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH v6 11/12] qtest/bios-tables-test: Make test build-independent from accelerator |
|
Date: |
Mon, 3 May 2021 16:19:43 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/3/21 4:10 PM, Philippe Mathieu-Daudé wrote:
> Now than we can probe if the TCG accelerator is available
that
> at runtime with a QMP command, do it once at the beginning
> and only register the tests we can run.
> We can then replace the #ifdef'ry by an assertion.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v5 had:
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
> v6 is simplified and keeps the same logic, however since
> it is different, I'm not keeping the R-b tags.
> ---
> tests/qtest/bios-tables-test.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v6 04/12] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM, (continued)
- [PATCH v6 04/12] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM, Philippe Mathieu-Daudé, 2021/05/03
- [PATCH v6 05/12] qtest/arm-cpu-features: Restrict sve_tests_sve_off_kvm test to KVM, Philippe Mathieu-Daudé, 2021/05/03
- [PATCH v6 06/12] qtest/arm-cpu-features: Remove TCG fallback to KVM specific tests, Philippe Mathieu-Daudé, 2021/05/03
- [PATCH v6 07/12] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for TCG, Philippe Mathieu-Daudé, 2021/05/03
- [PATCH v6 08/12] qtest/migration-test: Skip tests if KVM not builtin on s390x/ppc64, Philippe Mathieu-Daudé, 2021/05/03
- [PATCH v6 09/12] qtest/bios-tables-test: Rename tests not TCG specific, Philippe Mathieu-Daudé, 2021/05/03
- [PATCH v6 10/12] qtest/bios-tables-test: Rename TCG specific tests, Philippe Mathieu-Daudé, 2021/05/03
- [PATCH v6 11/12] qtest/bios-tables-test: Make test build-independent from accelerator, Philippe Mathieu-Daudé, 2021/05/03
- [PATCH v6 12/12] qtest: Do not restrict bios-tables-test to Aarch64 hosts anymore, Philippe Mathieu-Daudé, 2021/05/03
- Re: [PATCH v6 00/12] qtests: Check accelerator available at runtime via QMP 'query-accels', Michael S. Tsirkin, 2021/05/14