[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 05/12] qtest/arm-cpu-features: Restrict sve_tests_sve_off_
From: |
Alex Bennée |
Subject: |
Re: [PATCH v4 05/12] qtest/arm-cpu-features: Restrict sve_tests_sve_off_kvm test to KVM |
Date: |
Fri, 30 Apr 2021 10:51:56 +0100 |
User-agent: |
mu4e 1.5.12; emacs 28.0.50 |
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> The sve_tests_sve_off_kvm() test is KVM specific.
> Only run it if KVM is available.
>
> Suggested-by: Andrew Jones <drjones@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/qtest/arm-cpu-features.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qtest/arm-cpu-features.c b/tests/qtest/arm-cpu-features.c
> index 7f4b2521277..66300c3bc20 100644
> --- a/tests/qtest/arm-cpu-features.c
> +++ b/tests/qtest/arm-cpu-features.c
> @@ -604,6 +604,8 @@ int main(int argc, char **argv)
> if (g_str_equal(qtest_get_arch(), "aarch64") && qtest_has_accel("kvm")) {
> qtest_add_data_func("/arm/kvm/query-cpu-model-expansion",
> NULL, test_query_cpu_model_expansion_kvm);
> + qtest_add_data_func("/arm/kvm/query-cpu-model-expansion/sve-off",
> + NULL, sve_tests_sve_off_kvm);
> }
>
> if (g_str_equal(qtest_get_arch(), "aarch64")) {
> @@ -611,8 +613,6 @@ int main(int argc, char **argv)
> NULL, sve_tests_sve_max_vq_8);
> qtest_add_data_func("/arm/max/query-cpu-model-expansion/sve-off",
> NULL, sve_tests_sve_off);
> - qtest_add_data_func("/arm/kvm/query-cpu-model-expansion/sve-off",
> - NULL, sve_tests_sve_off_kvm);
> }
>
> return g_test_run();
--
Alex Bennée
- Re: [PATCH v4 01/12] MAINTAINERS: Add qtest/arm-cpu-features.c to ARM TCG CPUs section, (continued)
- [PATCH v4 02/12] accel: Introduce 'query-accels' QMP command, Philippe Mathieu-Daudé, 2021/04/15
- [PATCH v4 03/12] tests/qtest: Add qtest_has_accel() method, Philippe Mathieu-Daudé, 2021/04/15
- [PATCH v4 04/12] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM, Philippe Mathieu-Daudé, 2021/04/15
- [PATCH v4 05/12] qtest/arm-cpu-features: Restrict sve_tests_sve_off_kvm test to KVM, Philippe Mathieu-Daudé, 2021/04/15
- [PATCH v4 06/12] qtest/arm-cpu-features: Remove TCG fallback to KVM specific tests, Philippe Mathieu-Daudé, 2021/04/15
- [PATCH v4 07/12] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for TCG, Philippe Mathieu-Daudé, 2021/04/15
- [PATCH v4 08/12] qtest/bios-tables-test: Make test build-independent from accelerator, Philippe Mathieu-Daudé, 2021/04/15
- [PATCH v4 09/12] qtest/migration-test: Skip tests if KVM not builtin on s390x/ppc64, Philippe Mathieu-Daudé, 2021/04/15